Skip to content

gh-106320: Move private _PyGen API to the internal C API#107032

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:internal_gen_types
Jul 22, 2023
Merged

gh-106320: Move private _PyGen API to the internal C API#107032
vstinner merged 1 commit intopython:mainfrom
vstinner:internal_gen_types

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 22, 2023 •
edited by bedevere-bot
Loading

Move private _PyGen API to internal C API:

  • _PyAsyncGenAThrow_Type
  • _PyAsyncGenWrappedValue_Type
  • _PyCoroWrapper_Type
  • _PyGen_FetchStopIterationValue()
  • _PyGen_Finalize()
  • _PyGen_SetStopIterationValue()

No longer these symbols, except of the ones by the _asyncio shared extensions.

@vstinner
pythongh-106320: Move private _PyGen API to the internal C API
e2f432c 
Move private _PyGen API to internal C API:

* _PyAsyncGenAThrow_Type
* _PyAsyncGenWrappedValue_Type
* _PyCoroWrapper_Type
* _PyGen_FetchStopIterationValue()
* _PyGen_Finalize()
* _PyGen_SetStopIterationValue()

No longer these symbols, except of the ones by the _asyncio shared
extensions.
@vstinner vstinner requested a review from markshannon as a code owner July 22, 2023 13:54
@bedevere-bot bedevere-bot mentioned this pull request Jul 22, 2023
Closed
@vstinner vstinner enabled auto-merge (squash) July 22, 2023 14:04
@vstinner vstinner merged commit ae8b114 into python:main Jul 22, 2023
@vstinner vstinner deleted the internal_gen_types branch July 22, 2023 14:47
@rdb
Copy link

rdb commented Aug 4, 2023

If _PyGen_FetchStopIterationValue is no longer public, what is the supported replacement we should use in our project?

rdb added a commit to panda3d/panda3d that referenced this pull request Aug 5, 2023
@rdb
event: Replace _PyGen_FetchStopIterationValue in Python 3.13+
0bc290e 
See python/cpython#106320 and python/cpython#107032

Closes #1526
@vstinner
Copy link
Member Author

vstinner commented Aug 16, 2023

@rdb:

If _PyGen_FetchStopIterationValue is no longer public, what is the supported replacement we should use in our project?

Would you mind to open a new issue to request a public replacement function? Please explain how you use this function, and how existing API is not enough.

@rdb
Copy link

rdb commented Aug 26, 2023 •
edited
Loading

@vstinner We've switched to using PyErr_GetRaisedException() and extracting the value from there (see this commit), so as long as the structure of PyStopIterationObject remains part of the public ABI, I think we're good.

@vstinner
Copy link
Member Author

vstinner commented Aug 26, 2023

When can add a public function. Just open an issue to ask for it, so we can discuss the issue and decide if it's worth it

@rdb
Copy link

rdb commented Aug 26, 2023

It's not necessary, unless you're telling me that PyStopIterationObject is going to become opaque in the future.

lachbr pushed a commit to toontownretro/panda that referenced this pull request Feb 17, 2024
@rdb
event: Replace _PyGen_FetchStopIterationValue in Python 3.13+
043417b 
See python/cpython#106320 and python/cpython#107032

Closes #1526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @rdb @bedevere-bot